Home Explore Help
Register Sign In
kiwec
/
McOsu
1
0
Fork 1
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Fix songs failing to restart

You can't call setPositionMS_fast on a stream after it used the regular
setPositionMS! Or else the call would get ignored.
kiwec 2 months ago
parent
7db7263ef5
commit
32124eadfa
2 changed files with 13 additions and 9 deletions
Split View Show Diff Stats
  1. 13 8
      src/App/Osu/Changelog.cpp
  2. 0 1
      src/Engine/Sound.cpp

+ 13 - 8
src/App/Osu/Changelog.cpp
View File 

@@ -29,16 +29,21 @@ Changelog::Changelog() : ScreenBackable() {
 
     CHANGELOG latest;
 
     latest.title =
 
         UString::format("%.2f (%s, %s)", convar->getConVarByName("osu_version")->getFloat(), __DATE__, __TIME__);
 
-    latest.changes.push_back("- Added sort_skins_by_name convar");
 
-    latest.changes.push_back("- Added setting to prevent servers from replacing the main menu logo");
 
-    latest.changes.push_back("- Chat: added missing chat commands");
 
-    latest.changes.push_back("- Chat: added missing keyboard shortcuts");
 
-    latest.changes.push_back("- Chat: added support for user links");
 
-    latest.changes.push_back("- Chat: improved map link support");
 
-    latest.changes.push_back("- Fixed freeze when switching between songs in song browser");
 
-    latest.changes.push_back("- Lowered audio latency for default (not ASIO/WASAPI) output");
 
+    latest.changes.push_back("- Fixed songs failing to restart");
 
     changelogs.push_back(latest);
 
 
+    CHANGELOG v35_07;
 
+    v35_07.title = "35.07 (2024-06-27)";
 
+    v35_07.changes.push_back("- Added sort_skins_by_name convar");
 
+    v35_07.changes.push_back("- Added setting to prevent servers from replacing the main menu logo");
 
+    v35_07.changes.push_back("- Chat: added missing chat commands");
 
+    v35_07.changes.push_back("- Chat: added missing keyboard shortcuts");
 
+    v35_07.changes.push_back("- Chat: added support for user links");
 
+    v35_07.changes.push_back("- Chat: improved map link support");
 
+    v35_07.changes.push_back("- Fixed freeze when switching between songs in song browser");
 
+    v35_07.changes.push_back("- Lowered audio latency for default (not ASIO/WASAPI) output");
 
+    changelogs.push_back(v35_07);
 
+
 
     CHANGELOG v35_06;
 
     v35_06.title = "35.06 (2024-06-17)";
 
     v35_06.changes.push_back("- Added cursor trail customization settings");

+ 0 - 1
src/Engine/Sound.cpp
View File 

@@ -198,7 +198,6 @@ void Sound::destroy() {
 
 void Sound::setPosition(double percent) { return setPositionMS(clamp<f64>(percent, 0.0, 1.0) * m_length); }
 
 
 void Sound::setPositionMS(unsigned long ms) {
 
-    if(ms == 0) return setPositionMS_fast(ms);
 
     if(!m_bReady || ms > getLengthMS()) return;
 
     if(!m_bStream) {
 
         engine->showMessageError("Programmer Error", "Called setPositionMS on a sample!");