Browse Source

Update default value of some convars

kiwec 2 months ago
parent
commit
aba5a673a5

+ 1 - 1
src/App/Osu/HitObject.cpp

@@ -83,7 +83,7 @@ ConVar osu_mod_approach_different_style(
     "Decelerate1, 8 = Decelerate2, 9 = Decelerate3");
 
 ConVar osu_relax_offset(
-    "osu_relax_offset", 0, FCVAR_DEFAULT,
+    "osu_relax_offset", -12, FCVAR_DEFAULT,
     "osu!relax always hits -12 ms too early, so set this to -12 (note the negative) if you want it to be the same");
 
 ConVar *HitObject::m_osu_approach_scale_multiplier_ref = &osu_approach_scale_multiplier;

+ 14 - 1
src/App/Osu/MainMenu.cpp

@@ -212,10 +212,23 @@ MainMenu::MainMenu() : OsuScreen() {
             if(versionFile.canRead()) {
                 float version = std::stof(versionFile.readLine());
                 if(version < Osu::version->getFloat() - 0.0001f) m_bDrawVersionNotificationArrow = true;
-                if(version < 34.05) {
+                if(version < 35.06) {
                     // SoundEngine choking issues have been fixed, option has been removed from settings menu
                     // We leave the cvar available as it could still be useful for some players
                     convar->getConVarByName("restart_sound_engine_before_playing")->setValue(false);
+
+                    // 0.5 is shit default value
+                    auto search_delay = convar->getConVarByName("osu_songbrowser_search_delay");
+                    if(search_delay->getFloat() == 0.5f) {
+                        search_delay->setValue(0.2f);
+                    }
+
+                    // Match osu!stable value
+                    auto relax_offset = convar->getConVarByName("osu_relax_offset");
+                    if(relax_offset->getFloat() == 0.f) {
+                        relax_offset->setValue(-12.f);
+                    }
+
                     osu->getOptionsMenu()->save();
                 }
             } else {

+ 3 - 0
src/App/Osu/OptionsMenu.cpp

@@ -3607,9 +3607,12 @@ void OptionsMenu::save() {
     std::vector<ConVar *> manualConVars;
     std::vector<ConVar *> removeConCommands;
 
+    manualConVars.push_back(convar->getConVarByName("osu_relax_offset"));
     manualConVars.push_back(convar->getConVarByName("osu_songbrowser_sortingtype"));
     manualConVars.push_back(convar->getConVarByName("osu_songbrowser_scores_sortingtype"));
+    manualConVars.push_back(convar->getConVarByName("osu_songbrowser_search_delay"));
     manualConVars.push_back(convar->getConVarByName("mp_autologin"));
+    manualConVars.push_back(convar->getConVarByName("restart_sound_engine_before_playing"));
     manualConVars.push_back(m_osu_notelock_type_ref);
     manualConVars.push_back(m_osu_drain_type_ref);
 

+ 2 - 2
src/App/Osu/Osu.cpp

@@ -148,7 +148,7 @@ ConVar restart_sound_engine_before_playing("restart_sound_engine_before_playing"
 ConVar instafade("instafade", false, FCVAR_DEFAULT, "don't draw hitcircle fadeout animations");
 
 ConVar use_https("use_https", true, FCVAR_DEFAULT);
-ConVar mp_server("mp_server", "ez-pp.farm", FCVAR_DEFAULT);
+ConVar mp_server("mp_server", "akatsuki.gg", FCVAR_DEFAULT);
 ConVar mp_password("mp_password", "", FCVAR_DEFAULT | FCVAR_HIDDEN);
 ConVar mp_autologin("mp_autologin", false, FCVAR_DEFAULT);
 ConVar submit_scores("submit_scores", false, FCVAR_DEFAULT);
@@ -178,7 +178,7 @@ Osu::Osu() {
 
     bancho.neosu_version = UString::format("%.2f-" NEOSU_STREAM, osu_version.getFloat());
     bancho.user_agent =
-        UString::format("Mozilla/5.0 (compatible; neosu/%s; +" NEOSU_UPDATE_URL "/)", bancho.neosu_version.toUtf8());
+        UString::format("Mozilla/5.0 (compatible; neosu/%s; +" NEOSU_URL "/)", bancho.neosu_version.toUtf8());
 
     // convar refs
     m_osu_folder_ref = convar->getConVarByName("osu_folder");

+ 1 - 1
src/App/Osu/SongBrowser/SongBrowser.cpp

@@ -72,7 +72,7 @@ ConVar osu_draw_songbrowser_strain_graph("osu_draw_songbrowser_strain_graph", fa
 ConVar osu_songbrowser_scorebrowser_enabled("osu_songbrowser_scorebrowser_enabled", true, FCVAR_DEFAULT);
 ConVar osu_songbrowser_background_fade_in_duration("osu_songbrowser_background_fade_in_duration", 0.1f, FCVAR_DEFAULT);
 
-ConVar osu_songbrowser_search_delay("osu_songbrowser_search_delay", 0.5f, FCVAR_DEFAULT,
+ConVar osu_songbrowser_search_delay("osu_songbrowser_search_delay", 0.2f, FCVAR_DEFAULT,
                                     "delay until search update when entering text");
 void _osu_songbrowser_search_hardcoded_filter(UString oldValue, UString newValue);
 ConVar osu_songbrowser_search_hardcoded_filter("osu_songbrowser_search_hardcoded_filter", "", FCVAR_DEFAULT,